Re: [PATCH] dmi_check_system can generate Warnings when no DMItable is present

From: Daniel Walker
Date: Fri Oct 23 2009 - 08:48:01 EST


On Fri, 2009-10-23 at 13:49 +0200, Erwan Velu wrote:
> Ingo Molnar a Ãcrit :
> > Looks like a Xen bug. DMI matching functions should be called after that
> > code has initialized. The warning was added to catch such early calls.
> >
> > Your patch works around that bug and the warning.
> >
> So I think you'll drop it and we have to make xen people fix it ?

It's your defect, so you can still try to fix it (unless the "xen
people" or someone else beats you to it.)

It looks like on a normal system dmi_scan_machine() gets called very
early in setup_arch() arch/x86/kernel/setup.c . A possible good fix
might be to add a dmi_disable() into the dmi driver that just shuts off
dmi, and run that in xen_arch_setup() in arch/x86/xen/setup.c .

Daniel



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/