Re: [PATCH] sony_pi: Remove the BKL from sonypi_misc_open

From: John Kacur
Date: Mon Oct 19 2009 - 14:21:09 EST




On Mon, 19 Oct 2009, Arnd Bergmann wrote:

> On Sunday 18 October 2009, John Kacur wrote:
> > The BKL is in this function because of the BKL pushdown
> > (see commit f8f2c79d594463427f7114cedb1555110d547d89)
> >
> > It is not needed here because the mutex_lock sonypi_device.lock
> > provides the necessary locking.
>
> The driver still uses the BKL in the ioctl function, which can
> probably be removed at the same time.
>
> Arnd <><
>

How does this look? (Version 2 of the patch follows)