Re: [PATCH v2] SDMA: Fixing bug in omap_dma_set_global_params()

From: Tony Lindgren
Date: Wed Oct 07 2009 - 18:05:45 EST


* Randy Dunlap <rdunlap@xxxxxxxxxxxx> [091007 08:38]:
> On Wed, 7 Oct 2009 14:48:26 +0530 Venkatraman S wrote:
>
> > On Mon, Oct 5, 2009 at 10:11 PM, Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
> > > On Mon,  5 Oct 2009 14:12:43 +0530 Anuj Aggarwal wrote:
> > >
> > >> Argument tparams was not being used to program
> > >> global register GCR.HI_THREAD_RESERVED. This patch fixes the same.
> > >>
> > >> Signed-off-by: Anuj Aggarwal <anuj.aggarwal@xxxxxx>
> > >> ---
> > >>  arch/arm/plat-omap/dma.c |   15 +++++++++------
> > >>  1 files changed, 9 insertions(+), 6 deletions(-)
> > >
> > >
> > > Hi,
> > > Someone please convert all of this source file to correct kernel-doc notation.
> > >
> > > Thanks.
> > >
> >
> > I now have this on my TODO list. As a bug fix, shouldn't this be
> > pulled in and the doc updates for all the functions can be done as a
> > separate patch ?
>
> Yes. Thanks.

Will add this fix to my omap-fixes queue.

Tony

>
> > Anuj,
> > Can you please correct the comments for this function to proper
> > format along with your changes ?
> >
> > Thanks,
> > Venkat.
>
>
> ---
> ~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/