Re: [tip:timers/urgent] NOHZ: update idle state also when NOHZ isinactive

[Rik van Riel]

tip-bot for Eero Nurkkala wrote:
> Commit-ID:  fdc6f192e7e1ae80565af23cc33dc88e3dcdf184
> Gitweb:     http://git.kernel.org/tip/fdc6f192e7e1ae80565af23cc33dc88e3dcdf184
> Author:     Eero Nurkkala <ext-eero.nurkkala@xxxxxxxxx>
> AuthorDate: Wed, 7 Oct 2009 11:54:26 +0300
> Committer:  Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> CommitDate: Wed, 7 Oct 2009 13:05:05 +0200
>
> NOHZ: update idle state also when NOHZ is inactive
>
> Commit f2e21c9610991e95621a81407cdbab881226419b had unfortunate side
> effects with cpufreq governors on some systems.
>
> If the system did not switch into NOHZ mode ts->inidle is not set when
> tick_nohz_stop_sched_tick() is called from the idle routine. Therefor
> all subsequent calls from irq_exit() to tick_nohz_stop_sched_tick()
> fail to call tick_nohz_start_idle(). This results in bogus idle
> accounting information which is passed to cpufreq governors.
>
> Set the inidle flag unconditionally of the NOHZ active state to keep
> the idle time accounting correct in any case.

Acked-by: Rik van Riel <riel@xxxxxxxxxx>

--
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/