Re: [PATCH 2/2] Revert "Revert "ide: try to use PIO Mode 0 during probe if possible""

[Bartlomiej Zolnierkiewicz]

On Wednesday 07 October 2009 00:57:05 David Miller wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
> Date: Wed, 7 Oct 2009 00:52:37 +0200
> 
> > On Wednesday 07 October 2009 00:41:20 David Miller wrote:
> >> From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
> >> Date: Wed, 7 Oct 2009 00:27:45 +0200
> >> 
> >> > The root cause of reported system hangs was (now fixed) sis5513 bug
> >> > and not "ide: try to use PIO Mode 0 during probe if possible" change
> >> > (commit 6029336426a2b43e4bc6f4a84be8789a047d139e) so the revert was
> >> > incorrect (it simply replaced one regression with the other one).
> >> 
> >> What is this older "regression" fixed by the PIO-0 change?
> >> 
> >> You're not explaining it and neither does the commit message for the
> >> PIO-0 change.
> > 
> > It does:
> > 
> > | Subject: [PATCH] sis5513: fix PIO setup for ATAPI devices
> 
> Sorry, I wasn't clear.
> 
> I'm talking about commit 6029336426a2b43e4bc6f4a84be8789a047d139e, it
> doesn't say why we want to try PIO 0 mode during probe.

For the same reason that libata wants it.

Many embedded controllers/platforms will have junk PIO timings set initially.

Now that your manager's ambition is satisfied could you please go help
some other subsystem for the moment so we can fix ide in the meantime? :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/