Re: [Bug #14141] order 2 page allocation failures in iwlagn

From: KOSAKI Motohiro
Date: Mon Oct 05 2009 - 21:26:49 EST


> On Mon, 5 Oct 2009, Frans Pop wrote:
>
> > And the winner is:
> > 2ff05b2b4eac2e63d345fc731ea151a060247f53 is first bad commit
> > commit 2ff05b2b4eac2e63d345fc731ea151a060247f53
> > Author: David Rientjes <rientjes@xxxxxxxxxx>
> > Date: Tue Jun 16 15:32:56 2009 -0700
> >
> > oom: move oom_adj value from task_struct to mm_struct
> >
> > I'm confident that the bisection is good. The test case was very reliable
> > while zooming in on the merge from akpm.
> >
>
> I doubt it for two reasons: (i) this commit was reverted in 0753ba0 since
> 2.6.31-rc7 and is no longer in the kernel, and (ii) these are GFP_ATOMIC
> allocations which would be unaffected by oom killer scores.

I agree. this patch is pretty obvious correct. it was reverted by
one unfortunately regression.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/