Re: [PATCH 3/3] cgroup: fix strstrip() abuse

From: KOSAKI Motohiro
Date: Sat Oct 03 2009 - 08:13:41 EST


>> cgroup_write_X64() and cgroup_write_string() ignore the return
>> value of strstrip().
>> it makes small inconsistent behavior.
>>
>> example:
>> =========================
>>  # cd /mnt/cgroup/hoge
>>  # cat memory.swappiness
>>  60
>>  # echo "59 " > memory.swappiness
>>  # cat memory.swappiness
>>  59
>>  # echo " 58" > memory.swappiness
>>  bash: echo: write error: Invalid argument
>>
>>
>> This patch fixes it.
>>
>> Cc: Li Zefan <lizf@xxxxxxxxxxxxxx>
>> Cc: Paul Menage <menage@xxxxxxxxxx>
>> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
>
> Acked-by: Paul Menage <menage@xxxxxxxxxx>
>
> Thanks - although I think I'd s/abuse/misuse/ in the description.

I don't know what's different between them. My dictionary is slightly quiet ;)
Is this X-rated word? if so, I'll resend it soon.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/