Re: [this_cpu_xx V4 00/20] Introduce per cpu atomic operations andavoid per cpu address arithmetic

[Ingo Molnar]

* Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Fri, 2 Oct 2009, Ingo Molnar wrote:
> 
> > One final step/cleanup seems to be missing from it: it should 
> > replace current uses of percpu_op() [percpu_read(), etc.] in the x86 
> > tree and elsewhere with the new this_cpu_*() primitives. 
> > this_cpu_*() is using per_cpu_from_op/per_cpu_to_op directly, we 
> > dont need those percpu_op() variants anymore.
> 
> Well after things settle with this_cpu_xx we can drop those.
> 
> > There should also be a kernel image size comparison done for that 
> > step, to make sure all the new primitives are optimized to the max 
> > on the instruction level.
> 
> Right. There will be a time period in which other arches will need to 
> add support for this_cpu_xx first.

Size comparison should be only on architectures that support it (i.e. 
x86 right now). The generic fallbacks might be bloaty, no argument about 
that. ( => the more reason for any architecture to add optimizations for 
this_cpu_*() APIs. )

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/