Re: [PATCH] acerhdf: Limit modalias matching to supported boards

[Stefan Bader]

This is a multi-part message in MIME format.Peter Feuerer wrote:
> Borislav Petkov writes:
>
> > On Wed, Sep 30, 2009 at 02:13:55PM +0200, Stefan Bader wrote:
> > > We got reports of acerhdf issuing warnings on Acer laptops other
> > > than Aspire Ones. Looking at the dmi match this sounds a bit to
> > > generic. IOW the module gets loaded on any Acer laptop. After the
> > > following patch the module gets still loaded on my Aspire One but
> > > not on the reported other laptop.
> > > The same change might be helpful for the other two dmi matches, but
> > > I had no way of testing.
> >
> > Yeah, we might need someone with such a machine to give us
> > /sys/class/dmi/id/modalias content. Peter, do you have any users with
> > such machines?
>
> I search my acerhdf-inbox for the people who sent me the BIOS versions, 
> maybe they still have the netbook and can me send the modalias content. 
> I'll hopefully find some time upcoming weekend.
>
> But, can't we simply assume, following dmi lines?
>
> MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");
> MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");
> MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");
> MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");
>
> We have exactly those constellations within the BIOS settings table. If 
> I interpret the modalias line correctly, "pnAOA110" means "Product Name 
> AOA110" and that's what we have already in the BIOS settings table. So I 
> think we do already have all information we need to create a complete 
> patch for the problem, or am I wrong?

Right pn means that. I would strongly believe the above changes should be good. 
I sometimes tend to be over-cautious. Attaching a refreshed patch which 
includes them all.

-Stefan

> > > From 389f61f7e66ce615dc6418cb856e167edaa74b42 Mon Sep 17 00:00:00 2001
> > > From: Stefan Bader <stefan.bader@xxxxxxxxxxxxx>
> > > Date: Mon, 28 Sep 2009 17:11:29 +0000
> > > Subject: [PATCH] UBUNTU: acerhdf: Limit modalias matching to 
> > > supported boards
> > >
> > > BugLink: https://bugs.launchpad.net/ubuntu/+bug/435958
> > >
> > > The module alias currently matches any Acer computer but when loaded the
> > > BIOS checks will only succeed on Aspire One models. This causes a 
> > > invalid
> > > BIOS warning for all other models (seen on Aspire 4810T).
> > > This is not fatal but worries users that see this message. Limiting the
> > > moule alias to models starting with AOA. Probably the same change 
> > > should be
> > > made for the two other entries.
> > >
> > > Signed-off-by: Stefan Bader <stefan.bader@xxxxxxxxxxxxx>
> >
> > Acked-by: Borislav Petkov <petkovbb@xxxxxxxxx>
> >
> > > ---
> > >  drivers/platform/x86/acerhdf.c |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/platform/x86/acerhdf.c 
> > > b/drivers/platform/x86/acerhdf.c
> > > index aa298d6..763f233 100644
> > > --- a/drivers/platform/x86/acerhdf.c
> > > +++ b/drivers/platform/x86/acerhdf.c
> > > @@ -629,7 +629,7 @@ static void __exit acerhdf_exit(void)
> > >  MODULE_LICENSE("GPL");
> > >  MODULE_AUTHOR("Peter Feuerer");
> > >  MODULE_DESCRIPTION("Aspire One temperature and fan driver");
> > > -MODULE_ALIAS("dmi:*:*Acer*:*:");
> > > +MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:");
> > >  MODULE_ALIAS("dmi:*:*Gateway*:*:");
> > >  MODULE_ALIAS("dmi:*:*Packard Bell*:*:");
> > >  
> > > --
> > > 1.5.4.5
>
> kind regards,
> --peter


--

When all other means of communication fail, try words!