Re: [PATCH 1/5] checkpatch: fix false errors due to macroconcatenation

From: Daniel Walker
Date: Thu Oct 01 2009 - 10:20:34 EST


On Wed, 2009-09-30 at 18:46 +0100, Andy Whitcroft wrote:

> Ok, just removing these characters in the conversion changes the
> relative length of the converted form and breaks position reporting for
> other checks, for instance if I stupidly convert the ## to # so its
> still invalid we then get this:
>
> + entry = (struct ftrace_raw_##call *)raw_data; \
>
> It is probabally more correct to include this <ident> ## <ident> form in
> the definition of an identifier. I've respun this patch to do just that
> and it looks like its working as we would hope.

It could just become "__" something that would match on an ident and
keep the spacing the same.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/