Re: [PATCH] x86: add show_lapic=

[Cyrill Gorcunov]

[Cyrill Gorcunov - Mon, Sep 28, 2009 at 10:02:01PM +0400]
| [Yinghai Lu - Mon, Sep 28, 2009 at 10:46:54AM -0700]
| | On Mon, Sep 28, 2009 at 9:07 AM, Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:
| ...
| | >
| | > -__apicdebuginit(int) print_all_ICs(void)
| | > +static int __initdata show_lapic = 1;
| | > +static __init int setup_show_lapic(char *arg)
| | > +{
| | > +       int num = -1;
| | > +
| | > +       if (strcmp(arg, "all") == 0) {
| | > +               show_lapic = CONFIG_NR_CPUS;
| | 
| | NR_CPUS or nr_cpu_ids?
| 
| NR_CPUS as far as I can tell -- maximal to not exit for() loop until end.
| nr_cpu_ids safe here as well, but constant is better :)
| 
| | 
| | YH
| | 
| 	-- Cyrill

Yinghai, any news here? I would like to know your conclusion
on this patch.

	-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/