Re: [PATCH] Always print panic message on current console

[Bernhard Walle]

Hi,

Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>:
> > diff --git a/kernel/panic.c b/kernel/panic.c
> > index bcdef26..f9950e3 100644
> > --- a/kernel/panic.c
> > +++ b/kernel/panic.c
> > @@ -22,6 +22,7 @@
> > #include <linux/init.h>
> > #include <linux/nmi.h>
> > #include <linux/dmi.h>
> > +#include <linux/tty.h>
>
> It's odd that kmsg_redirect is declared in tty.h when it's purely a
> vt.c thing.  Why not vt.h?

Sorry, I don't know. It was there before my patch. :-)

> > int panic_on_oops;
> > static unsigned long tainted_mask;
> > @@ -65,6 +66,9 @@ NORET_TYPE void panic(const char * fmt, ...)
> > 	 */
> > 	preempt_disable();
> >
> > +	/* don't redirect the panic message to some hidden console */
> > +	kmsg_redirect = 0;
> > +
> > 	bust_spinlocks(1);
> > 	va_start(args, fmt);
> > 	vsnprintf(buf, sizeof(buf), fmt, args);
>
> Methinks CONFIG_HW_CONSOLE=n kernels won't link after making this
> change.
>
> I'd suggest something like
>
> #ifdef CONFIG_HW_CONSOLE
> extern void vt_set_kmsg_redirect(int vt);
> #else
> static inline void vt_set_kmsg_redirect(int vt)
> {
> }
> #endif

Sounds good. I will send a new patch for this.

> Another possible way of doing this would be for vt.c to hook itself
> into panic_notifier_list.  That's nice and clean from a
> separation-of-subsystems POV but isn't really conceptually correct - it
> assumes that other entries on panic_notifier_list don't print messages
> to the console.

I also thought about that, but I found it a bit oversized just for setting
a variable (in the panic case). Also, the panic() function does other things
(like blinking the keyboard LEDs) very direct, without abstraction. But
however, if you or other people think that this is the way to go, I have
no objections and will create a patch.


Regards,
Bernhard




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/