[PATCH] Make pty_driver and pty_slave_driver local vars in legacy BSDpty code

From: David Howells
Date: Wed Sep 30 2009 - 06:02:10 EST


Make the pty_driver and pty_slave_driver global variables into local vars of
legacy_pty_init() as that's the only thing that ever accesses the values.

Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
---

drivers/char/pty.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/drivers/char/pty.c b/drivers/char/pty.c
index 53761ce..6fe1f07 100644
--- a/drivers/char/pty.c
+++ b/drivers/char/pty.c
@@ -326,8 +326,6 @@ static const struct tty_operations pty_ops = {

/* Traditional BSD devices */
#ifdef CONFIG_LEGACY_PTYS
-static struct tty_driver *pty_driver, *pty_slave_driver;
-
static int pty_bsd_ioctl(struct tty_struct *tty, struct file *file,
unsigned int cmd, unsigned long arg)
{
@@ -356,6 +354,8 @@ static const struct tty_operations pty_ops_bsd = {

static void __init legacy_pty_init(void)
{
+ struct tty_driver *pty_driver, *pty_slave_driver;
+
if (legacy_count <= 0)
return;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/