Re: [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're notused

From: Alan Cox
Date: Tue Sep 29 2009 - 18:41:39 EST


On Tue, 29 Sep 2009 19:40:10 +0100
David Howells <dhowells@xxxxxxxxxx> wrote:

> Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> > Comments?
>
> Perhaps add legacy pty support to the list of features to be removed and see
> who howls.

You do break stuff still and they are part of the API, ABI and namespace
so you break compatibility.

> > static struct tty_driver *pty_driver, *pty_slave_driver;
>
> These shouldn't be global variables. They're only used within
> legacy_pty_init(). That's a side issue, however.

Agreed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/