Re: regression in page writeback

From: Christoph Hellwig
Date: Tue Sep 29 2009 - 10:21:58 EST


On Tue, Sep 29, 2009 at 10:32:27AM +0800, Wu Fengguang wrote:
> > This should help a bit for XFS as it historically does multi-page
> > writeouts from ->writepages (and apprently btrfs that added some
>
> ->writepage ?

Yes.

> > write-around recently?) but not those brave filesystems only
> > implementing the multi-page writeout from writepages as designed.
>
> Thanks. Just tried write_cache_pages(), looks simple. Need to further
> convert all aops->writepages to support lumpy pageout :)

Yeah. Most ->writepages instances are just copies of write_cache_pages
with local hacks. If you have any good idea to consolidate that that
would be great. Also XFS and btrfs do cluster move pages even from
->writepage, I wonder how well that interacts with reclaim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/