Re: [PATCH] percpu: fix unit_map[] verification in pcpu_setup_first_chunk()

From: Tejun Heo
Date: Mon Sep 28 2009 - 20:15:44 EST


Tony Vroon wrote:
> On Tue, 2009-09-29 at 01:19 +0900, Tejun Heo wrote:
>> pcpu_setup_first_chunk() incorrectly used NR_CPUS as the impossible
>> unit number while unit number can equal and go over NR_CPUS with
>> sparse unit map. This triggers BUG_ON() spuriously on machines which
>> have non-power-of-two number of cpus. Use UINT_MAX instead.
>>
>> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
>> Reported-by: Tony Vroon <tony@xxxxxxxx>
> Tested-by: Tony Vroon <tony@xxxxxxxx>
>
>> Erghh... stupid mistake. This should fix it. Can you please verify?
>
> Confirmed fixed. Thank you Tejun.

Thank you. Will push out later today.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/