Re: [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're notused

From: Alan Cox
Date: Mon Sep 28 2009 - 10:15:31 EST


On Mon, 28 Sep 2009 14:53:32 +0100
David Howells <dhowells@xxxxxxxxxx> wrote:

> Remove pty_ops_bsd as nothing appears to use it anymore. It results in the
> following warning:
>
> drivers/char/pty.c:344: warning: unused variable `pty_ops_bsd'
>
> if CONFIG_LEGACY_PTYS=y.
>
> Also remove pty_bsd_ioctl() as that's only referred to by pty_ops_bsd.
>
> Possibly legacy_pty_init() should be passing this to tty_set_operations()
> rather than pty_ops.

It should indeed, otherwise the BSD pty locking ioctl fails.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/