Re: [PATCH] kmemtrace: Fix up tracer registration.

From: Pekka Enberg
Date: Mon Sep 28 2009 - 04:38:00 EST


On Mon, Sep 28, 2009 at 10:55 AM, Paul Mundt <lethal@xxxxxxxxxxxx> wrote:
> Commit ddc1637af217dbd8bc51f30e6d24e84476a869a6
> ("kmemtrace: Print binary output only if 'bin' option is set") ended up
> inverting the error detection logic. register_tracer() returns 0 on
> success, which this change caused to treat as an error, resulting in:
>
> [    0.132000] Warning: could not register the kmem tracer
>
> as well as bailing out of the initcall with an error value. This
> restores the old logic.
>
> Signed-off-by: Paul Mundt <lethal@xxxxxxxxxxxx>

Looks good to me. Thanks Paul!

Acked-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/