Re: No more bits in vm_area_struct's vm_flags.

From: Nigel Cunningham
Date: Mon Sep 28 2009 - 01:29:21 EST


Hi.

KAMEZAWA Hiroyuki wrote:
> Seems good to me.
>
> Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> But
>> + if (vma->vm_hints)
>> + return 0;
>> return 1;
>
> Maybe adding a comment (or more detailed patch description) is necessary.

Thinking about this some more, I think we should also be looking at whether the new hints are non zero. Perhaps I should just add the new value to the
function parameters and be done with it.

Nigel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/