Re: [RFC Patch] kbuild: remove -Wdeclaration-after-statement

[Sam Ravnborg]

On Fri, Sep 25, 2009 at 01:18:52PM -0700, Randy Dunlap wrote:
> Sam Ravnborg wrote:
> > On Wed, Sep 23, 2009 at 05:38:01AM -0400, Amerigo Wang wrote:
> >> I got lots of "ISO C90 forbids mixed declarations and code" warnings
> >> during compile today's kernel.
> >>
> >> I think we can remove the gcc option '-Wdeclaration-after-statement'
> >> now, since we already have C99 for 10 years. :)
> > 
> > This is a matter of style more than what C99 allows.
> > Kernel style is to fobid this(*) so we keep the warning.
> 
> Agreed.
> 
> > (*) Based on reading several threads where this has
> > been mentioned - I have no specific references to CodingStyle.
> 
> I've avoided making updates to CodingStyle lately.
> Is this one needed?
No - CodingStyle should be general stuff.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/