Re: [GIT PULL] xen: Check NX state before setting up GDT mapping

[Ingo Molnar]

* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> On 09/23/09 05:36, Ingo Molnar wrote:
> >> +#ifdef CONFIG_X86_64
> >> +	/* Work out if we support NX */
> >> +	check_efer();
> >> +#endif
> >> +
> >>     
> > btw., this #ifdef could sure be eliminated, right?
> >   
> 
> check_efer() is only defined on x86-64 and all its existing callsites 
> have a similar #ifdef.

Yes, a familar pattern that prompted my comment.

> [...]  NX setup is an area which could do with a bit of hitting with 
> the unification stick.

Yes.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/