Re: v2.6.31-7381-g7fa0772: new build warnings: kmemcheck, __deprecated,hugetlb, radeon

From: Stefan Richter
Date: Wed Sep 23 2009 - 11:14:16 EST


Pekka Enberg wrote:
> On Wed, Sep 23, 2009 at 10:19 AM, Jean Delvare <khali@xxxxxxxxxxxx> wrote:
[...]
>> --- linux-2.6.32-pre.orig/include/linux/kmemcheck.h 2009-09-23 08:19:34.000000000 +0200
>> +++ linux-2.6.32-pre/include/linux/kmemcheck.h 2009-09-23 09:05:30.000000000 +0200
>> @@ -145,10 +145,12 @@ static inline bool kmemcheck_is_obj_init
>>
>> #define kmemcheck_annotate_bitfield(ptr, name) \
>> do { \
>> + int _n; \
>> + \
>> if (!ptr) \
>> break; \
>> \
>> - int _n = (long) &((ptr)->name##_end) \
>> + _n = (long) &((ptr)->name##_end) \
>> - (long) &((ptr)->name##_begin); \
>> BUILD_BUG_ON(_n < 0); \
>> \
>
> Oh, I was looking at an old version. The fix looks good to me, thanks Jean!
>
> Acked-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>

Things have been set into motion already, see akpm's comment to thread
"[PATCH] kmemcheck: clean up kmemcheck_annotate_bitfield",
http://lkml.org/lkml/2009/9/22/585
--
Stefan Richter
-=====-==--= =--= =-===
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/