Re: [patch] Re: [perf] Finding uninstalled modules Was Re: mailinglist for trace users

From: Avi Kivity
Date: Wed Sep 23 2009 - 11:10:22 EST


On 09/23/2009 06:05 PM, Mike Galbraith wrote:

Well, you don't need to do anything to open a file from cwd: that's the
default. You need to actively prepend /lib/modules/blah to get it to
load from the correct location. What I don't understand is why it is
only hitting me (esp. as it used to work).
If your modules.dep, always was missing the /lib/modules/blah bit, it
never worked for you. I wrote the thing with the rash assumption that
it always contained full path like mine does :)


Ah, changed there, I missed that part earlier, sorry. So it's probably a change in modules.dep generation instead of tools/perf.

So, I just need to check whether it's full path or not, prepend or take
the path as is, and hope there aren't several other ways to get screwed
up by modules.dep content.

Maybe we should fix that then (though I prefer relative paths myself).

Too bad the kernel doesn't store the path in /sys/modules/bla/path.
That would be nicer than rummaging around in a mutable file.

But then you rely on a running kernel. Be nice to be able to ship perf.data.

--

error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/