Re: [PATCH 5/7] ext4: Convert filesystem to the new truncatecalling convention

From: Jan Kara
Date: Tue Sep 22 2009 - 13:37:14 EST


On Tue 22-09-09 18:23:47, Al Viro wrote:
> On Tue, Sep 22, 2009 at 07:16:04PM +0200, Jan Kara wrote:
> > > No. We already have one half-finished series here; mixing it with another
> > > one is not going to happen. Such flags are tolerable only as bisectability
> > > helpers. They *must* disappear by the end of series. Before it can be
> > > submitted for merge.
> > >
> > > In effect, you are mixing truncate switchover with your writepage one.
> > > Please, split and reorder.
>
> > Well, this wasn't meant as a final version of those patches. It was
> > meant as a request for comment whether it makes sence to fix the problem
> > how I propose to fix it. If we agree on that, I'll go and convert the rest
> > of filesystems so that we can remove .new_writepage hack. By that time I
> > hope that new truncate sequence patches will be merged so that dependency
> > should go away as well...
>
> Could you carve just the ext4 part of truncate series out of that and
> post it separately?
Definitely. Actually, I've sent that patch to Nick in private but you're
right I should have posted it to the list as well. Will do it in a moment.
Thanks for a reminder.

Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/