Re: [RFC PATCH] delete unnecessary BUG_ON !policy->cur

[Luming Yu]

Patch attached!

On Tue, Sep 22, 2009 at 3:17 PM, Luming Yu <luming.yu@xxxxxxxxx> wrote:
> Hi there,
>
> When testing upstream Git tree, there is a BUG_ON hit on a IA64 system
> with RHEL 5 user space installed.
> Please review the patch below, If make sense, please apply.
>
> Ps. The patch is enclosed in attachment. The inlined one
> is c&p of it for reading.
>
>
> Thanks,
> Luming
>
> Signed-off-by: Yu Luming <luming.yu@xxxxxxxxx>
>
> Âcpufreq_userspace.c | Â Â1 -
> Â1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq_userspace.c
> b/drivers/cpufreq/cpufreq_userspace.c
> index 66d2d1d..63bd232 100644
> --- a/drivers/cpufreq/cpufreq_userspace.c
> +++ b/drivers/cpufreq/cpufreq_userspace.c
> @@ -119,7 +119,6 @@ static int cpufreq_governor_userspace(st
> Â Â Â Âcase CPUFREQ_GOV_START:
> Â Â Â Â Â Â Â Âif (!cpu_online(cpu))
> Â Â Â Â Â Â Â Â Â Â Â Âreturn -EINVAL;
> - Â Â Â Â Â Â Â BUG_ON(!policy->cur);
> Â Â Â Â Â Â Â Âmutex_lock(&userspace_mutex);
>
> Â Â Â Â Â Â Â Âif (cpus_using_userspace_governor == 0) {
>

Attachment: 10.patch
Description: Binary data