Re: [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments amc6821 chip

[Andrew Morton]

On Wed, 9 Sep 2009 09:34:35 +0200
Jean Delvare <khali@xxxxxxxxxxxx> wrote:

> > #define set_temp_para(name, reg)\
> > static ssize_t set_##name(\
> > 		struct device *dev,\
> > 		struct device_attribute *attr,\
> > 		const char *buf,\
> > 		size_t count)\
> > {\
> > 	return set_helper(dev, attr, buf, count, &dev->name);\
> > }
> > 
> > And then do all the real work in a common function?  Rather than
> > expanding tens of copies of the same thing?
> 
> Yes please. We got rid of macro-generated callbacks in most hwmon
> drivers a couple years ago already.

I never received an update to this patch so I'm retaining it in my tree
for now.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/