Re: HugeTLB: Driver example

[Alexey Korolev]

Mel,

> I think Christoph's point is that there should be an in-kernel user of the
> altered interface to hugetlbfs before the patches are merged. This example
> driver could move to samples/ and then add another patch converting some
> existing driver to use the new interface. Looking at the example driver,
> I'm hoping that converting an existing driver of interest would not be a
> massive undertaking.

Converting an existing driver may be a very difficult task as this
assumes involving in development process of the particular driver i.e.
having enough details about h/w and drivers and  having ability to
test the results. Also it is necessary to motivate maintainers to
accept this conversion. So I likely would not to be able change the
third party drivers for these reasons, but I'm open to help other
people to migrate if they want.
I heard that other people were asking you about driver interfaces for
huge pages, if this was about in-tree drivers then we could help each
other. Could you put me in touch with other developers you know of who
are interested in using htlb in drivers? It makes sense to get this
feature merged as it provides a quite efficient way for performance
increase. According to our test data, applying these little changes
gives about 7-10% gain.


> I tend to agree with him.
>
> As I'm having trouble envisioning what a real driver would look like,
> converting an in-kernel driver ensures that the interface was sane instead
> of exporting symbols that turn out to be unusable later. It'll also force
> any objectors out of the closet sooner rather than later.
>
> As it stands, I have no problems with the patches as such other than they
> need a bit more spit and polish. The basic principal seems ok.

Thanks,
Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/