Re: [PATCH] x86: Don't ack_APIC_irq() if lapic is disabled inGENERIC_INTERRUPT_VECTOR handler

[Ingo Molnar]

* Sheng Yang <sheng@xxxxxxxxxxxxxxx> wrote:

> Otherwise would cause trouble...
> 
> Cc: Dimitri Sivanich <sivanich@xxxxxxx>
> Signed-off-by: Sheng Yang <sheng@xxxxxxxxxxxxxxx>
> ---
>  arch/x86/kernel/irq.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
> index b0cdde6..78b23d0 100644
> --- a/arch/x86/kernel/irq.c
> +++ b/arch/x86/kernel/irq.c
> @@ -257,7 +257,8 @@ void smp_generic_interrupt(struct pt_regs *regs)
>  {
>  	struct pt_regs *old_regs = set_irq_regs(regs);
>  
> -	ack_APIC_irq();
> +	if (!disable_apic)
> +		ack_APIC_irq();

Wont in that case the apic->ack method be a NOP?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/