Re: [PATCH 7/8] perf: Add a perf record --timechart option

[Ingo Molnar]

* Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

> On Mon, 14 Sep 2009 10:06:00 +0200
> Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> 
> > On Sat, 2009-09-12 at 13:06 +0200, Arjan van de Ven wrote:
> > > This patch adds a "perf record --timechart" option, to make it easy
> > > to capture traces for use by the timechart tool.
> > 
> > Would it perhaps make sense to make that:
> > 
> >  perf timechart record
> 
> well yes, but it would just be an alias for the former, since it's the 
> record code that has to do the recording... and that's a rather 
> obscene layering violation in how perf is set up I think.

No, please do it like 'perf sched record' does - it constructs an 
argument list of pre-cooked options. See builtin-sched.c's record_args[] 
array.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/