Re: [PATCH 2/2] tracing: Document HAVE_FTRACE_SYSCALLS needs

From: Ingo Molnar
Date: Sat Sep 19 2009 - 03:28:41 EST



* Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:

> On Sat, Sep 19, 2009 at 09:17:12AM +0200, Ingo Molnar wrote:
> >
> > * Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> >
> > > Document the arch needed requirements to get the support for syscalls
> > > tracing.
> > >
> > > Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> > > Cc: Ingo Molnar <mingo@xxxxxxx>
> > > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > > Cc: Li Zefan <lizf@xxxxxxxxxxxxxx>
> > > Cc: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> > > Cc: Jason Baron <jbaron@xxxxxxxxxx>
> > > Cc: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
> > > Cc: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> > > Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> > > Cc: Paul Mundt <lethal@xxxxxxxxxxxx>
> > > ---
> > > Documentation/trace/ftrace-design.txt | 11 ++++++++++-
> > > 1 files changed, 10 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/Documentation/trace/ftrace-design.txt b/Documentation/trace/ftrace-design.txt
> > > index 7003e10..04ab61c 100644
> > > --- a/Documentation/trace/ftrace-design.txt
> > > +++ b/Documentation/trace/ftrace-design.txt
> > > @@ -216,7 +216,16 @@ If you can't trace NMI functions, then skip this option.
> > > HAVE_FTRACE_SYSCALLS
> > > ---------------------
> > >
> > > -<details to be filled>
> > > +You need very few things to get the syscalls tracing in an arch.
> > > +
> > > +- Have a NR_syscalls variable in <asm/unistd.h> that provides the number
> > > + of syscalls supported by the arch.
> > > +- Implement arch_syscall_addr() that resolves a syscall address from a
> > > + syscall number.
> > > +- Support the TIF_SYSCALL_TRACEPOINT thread flags
> > > +- Put the trace_sys_enter() and trace_sys_exit() tracepoints calls from ptrace
> > > + in the ptrace syscalls tracing path.
> > > +- Tag this arch as HAVE_FTRACE_SYSCALLS.
> >
> > HAVE_FTRACE_SYSCALLS is not actually used anywhere.
> >
> > Ingo
>
> Ah, that has been renamed HAVE_SYSCALL_TRACEPOINTS recently. What do
> you prefer? A delta patch or a rebase?

We need the acks from Martin/Heiko so lets wait for that and do a new
tree then?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/