Re: [PATCH] virtio_console: Add support for multiple ports forgeneric guest and host communication

From: Amit Shah
Date: Sat Sep 19 2009 - 03:05:26 EST


On (Fri) Sep 18 2009 [10:57:59], H. Peter Anvin wrote:
> On 09/18/2009 10:55 AM, Anthony Liguori wrote:
> >
> > I fail to see how this is at all relevant. This is a virtual machine,
> > we're presenting virtual hardware that behaves like a serial device.
> > Where web servers fit in is completely beyond me.
> >
>
> s/virtio_console/virtio_serial/
>
> There is a fairly noticeable difference between a "console device" and a
> "serial device". However, something that can be extended and exported
> to a physical serial port is definitely the latter.

The patch series did start out as a virtio_serial device. The qemu
maintainers had a problem supporting both, the pre-existing
virtio_console device and the new virtio_serial device as in essence
they're the same thing. So even though this patch adds all the support
in the virtio_console driver, it's really a virtio_serial transport with
a console supported on one of the ports (or multiple, if needed).

To maintain backward compatibility in the current scenario, though, I
chose not to rename the virtio_console driver to virtio_serial.

Amit
--
http://log.amitshah.net/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/