Re: [PATCH][uart] fit blackfin uart over sport driver into common uart inftrastructure (v2)

[Mike Frysinger]

On Fri, Sep 18, 2009 at 00:54, Sonic Zhang wrote:
> On Thu, Sep 17, 2009 at 2:56 AM, Mike Frysinger wrote:
>> On Wed, Sep 16, 2009 at 06:02, sonic zhang wrote:
>>> 3. Move most platform data into arch specific board files.
>>
>> might as well do it right now since you've done most of it already.
>> i.e. all of the peripheral logic should be in the boards, not the
>> driver. Âso the bfin_uart_pin_req_sportx lists should get moved to the
>> platform resources as well as the SPORT base addresses.
>
> No. You can't. Because the console is registered and running much
> earlier than the platform data is initialized. You have to know the
> peripheral lists and base address before registering the console.

this is why the early_platform_driver framework was created.  i was
looking into adding this to the Blackfin serial driver.  check out
Documentation/driver-model/platform.txt.

>>> Signed-off-by: Michael Frysinger <michael.frysinger@xxxxxxxxxx>
>>
>> you shouldnt add s-o-b tags for people who didnt opt for them ... i
>> was sleeping when you wrote, committed, and e-mailed out these
>> changes. Âi also handt posted these changes yet because i knew there
>> were still issues to be worked out.
>
> OK. I mean you also did some cleanup to this patch.

well once we get these issues hashed out, i'm happy to say the code is
good stuff ;)
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/