Re: [patch] Makefile: can't build modules outside the kernel tree if it was built using O=

[AmÃrico Wang]

On Thu, Sep 17, 2009 at 7:45 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Thursday 17 September 2009, Caveh Jalali wrote:
>
>> when the platform specific include directories were shuffled around
>> without updating the
>> top level Makefile. Âhowever, i think this FAIL is generic, and not
>> limited to powerpc.
>> here's a patch to the top level Makefile to teach it about the shuffled files:
>>
>>
>> --- /local/caveh/linux/linux-2.6.31/Makefile  Â2009-09-09
>> 15:13:59.000000000 -0700
>> +++ Makefile  Â2009-09-16 12:23:05.000000000 -0700
>> @@ -958,9 +958,9 @@ ifneq ($(KBUILD_SRC),)
>> Â Â Â Â Â Â Â Â echo " Âin the '$(srctree)' directory.";\
>> Â Â Â Â Â Â Â Â /bin/false; \
>> Â Â Â Â fi;
>> -    $(Q)if [ ! -d include2 ]; then                 Â\
>> - Â Â Â Â Â mkdir -p include2; Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â\
>> - Â Â Â Â Â ln -fsn $(srctree)/include/asm-$(SRCARCH) include2/asm; Â Â \
>> +    $(Q)if [ ! -d include2 ]; then                  \
>> + Â Â Â Â Â mkdir -p include2; Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â \
>> + Â Â Â Â Â ln -fsn $(srctree)/arch/$(SRCARCH)/include/asm include2/asm; \
>> Â Â Â Â fi
>> Âendif
>
> I think we should no longer have the include2 directory at all with new kernels.
>
> LINUXINCLUDE already contains the right path in theory:
>
> LINUXINCLUDE Â Â:= -Iinclude \
> Â Â Â Â Â Â Â Â Â $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include) \
>          -I$(srctree)/arch/$(hdr-arch)/include        \
> Â Â Â Â Â Â Â Â Â -include include/linux/autoconf.h

Hmm, at least in mmotm, we still have include2...

Maybe Sam is queueing the patches to remove include2?
¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶ŸÿÃ-»+ƒùdš_