Re: [PATCH] fix BUILD_BUG_ON() and a couple of bogus uses of it

From: David Miller
Date: Thu Sep 17 2009 - 20:31:47 EST


From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Date: Thu, 17 Sep 2009 17:15:04 -0700

> There's a shortcoming in the current BUILD_BUG_ON() - it silently does
> nothing if passed a non-constant arg.
>
> I suspect that in the 2.6.31 code, that BUILD_BUG_ON() just does
> nothing at all, and that Jan's patch is now exposing this. It might be
> compiler-version dependent too.
>
>
> <tests it>
>
> Yup, on base 2.6.31, this:

Ok, I'll have to either change this function to a macro or
get rid of the check.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/