Re: [Xen-devel] Re: [PATCH][v2.6.29][XEN] Return unused memory tohypervisor

From: Miroslav Rezanina
Date: Thu Sep 17 2009 - 04:14:16 EST


Hi Jeremy,
I check your application. It won't work correctly. You are calling return_unused_memory in xen_memory_setup that is too soon.
When you are calling it, there is no hole in map in any case. Calling should be in xen_post_allocator_init function (in arch/x86/xen/mmu.c).

Mirek
----- "Jeremy Fitzhardinge" <jeremy@xxxxxxxx> wrote:

> From: "Jeremy Fitzhardinge" <jeremy@xxxxxxxx>
> To: "Miroslav Rezanina" <mrezanin@xxxxxxxxxx>
> Cc: "Konrad Rzeszutek Wilk" <konrad.wilk@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
> Sent: Thursday, September 17, 2009 6:54:56 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
> Subject: Re: [Xen-devel] Re: [PATCH][v2.6.29][XEN] Return unused memory to hypervisor
>
> On 09/16/09 21:43, Miroslav Rezanina wrote:
> > Ups.....This should not be commented out. I will resent the patch
> with
> > correct (uncommented) line.
>
> I've already applied a variant of your patch. Check the
> rebase/core-freemem branch in xen.git.
>
> J
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
Miroslav Rezanina
Software Engineer - Virtualization Team - XEN kernel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/