[tip:tracing/core] tracing: Fix minor bugs for __unregister_ftrace_function_probe

From: tip-bot for Atsushi Tsuji
Date: Thu Sep 17 2009 - 03:49:02 EST


Commit-ID: b36461da2a0389149d7f88f3cbc05a30d1db9faa
Gitweb: http://git.kernel.org/tip/b36461da2a0389149d7f88f3cbc05a30d1db9faa
Author: Atsushi Tsuji <a-tsuji@xxxxxxxxxxxxx>
AuthorDate: Tue, 15 Sep 2009 19:06:30 +0900
Committer: Steven Rostedt <rostedt@xxxxxxxxxxx>
CommitDate: Wed, 16 Sep 2009 09:08:54 -0400

tracing: Fix minor bugs for __unregister_ftrace_function_probe

Fix the condition of strcmp for "*".
Also fix NULL pointer dereference when glob is NULL.

Signed-off-by: Atsushi Tsuji <a-tsuji@xxxxxxxxxxxxx>
LKML-Reference: <4AAF6726.5090905@xxxxxxxxxxxxx>
Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>


---
kernel/trace/ftrace.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 8b23d56..f7ab7fc 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -2062,9 +2062,9 @@ __unregister_ftrace_function_probe(char *glob, struct ftrace_probe_ops *ops,
int i, len = 0;
char *search;

- if (glob && (strcmp(glob, "*") || !strlen(glob)))
+ if (glob && (strcmp(glob, "*") == 0 || !strlen(glob)))
glob = NULL;
- else {
+ else if (glob) {
int not;

type = ftrace_setup_glob(glob, strlen(glob), &search, &not);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/