Re: [PATCH] blackfin: Cleanup linker script using new linker script macros.

From: Mike Frysinger
Date: Wed Sep 16 2009 - 12:56:39 EST


On Wed, Sep 16, 2009 at 11:58, Tim Abbott wrote:
> On Tue, 15 Sep 2009, Mike Frysinger wrote:
>> the larger padding in the initramfs is kind of annoying as i cant see
>> any need to pad it to PAGE_SIZE. Âsince the initramfs is released with
>> the rest of the init section, it doesnt need whole pages. Âa quick
>> test shows that it does waste a few kb in reality. Âdefault build for
>> BF533-STAMP for example shows 0x1000 difference.
>
> OK. ÂI guess we should plan to modify the INIT_DATA_SECTION macro to add
> another argument specifying an alignment level for .init.ramfs. ÂIt'd be
> inconvenient to add that right now since there are a lot of patches in
> linux-next or otherwise in flight that introduce uses of
> INIT_DATA_SECTION, and those patches would all be broken by changing this
> now. ÂOnce the dust settles on that for this release, I'll submit a patch
> adding said argument to INIT_DATA_SECTION.

sounds good to me. too bad the function alignment isnt specified in
arch linkage.h, otherwise i'd suggest we default to that rather than
PAGE_SIZE. as seen in the current Blackfin linker script, we only
need the normal .text alignment of 4 bytes.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/