Re: [RFC][PATCH 08/10] x86: Don't ack_APIC_irq() if lapic isdisabled in GENERIC_INTERRUPT_VECTOR handler

From: Cyrill Gorcunov
Date: Wed Sep 16 2009 - 05:37:41 EST


[Cyrill Gorcunov - Wed, Sep 16, 2009 at 01:03:06PM +0400]
| [Cyrill Gorcunov - Wed, Sep 16, 2009 at 12:58:35PM +0400]
| ...
| |
| | Hi Sheng,
| |
| | is there was some problem with it? I'm asking you
| | because if disable_apic=1 then any apic write/read
| | operations become NOPs. So I don't see how it may
| | hurt. But I could be missing something.
| |
| | -- Cyrill
|
| Ah, I see -- it's due to your other patch...
| Hmm this makes all "disable apic" idea less
| general. And safety of ack_APIC_irq is now
| under suspicious.
|
| -- Cyrill

And how msi_compose_msg would work then?

Don't get me wrong please, I'm just trying to understand.
Perhaps Xen specifics will handle it (I didn't read Xen
internals) by substituting all this with own handler.

Since comments are requested I thought I may ask? :)

-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/