Re: [BUGFIX][mmotm] fix walk system ram range patch (Was Re: mmotm on powerpc: walk_memory_resource?

[AmÃrico Wang]

2009/9/16 KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>:
> On Tue, 15 Sep 2009 22:36:26 +0100 (BST)
> Hugh Dickins <hugh.dickins@xxxxxxxxxxxxx> wrote:
>
>> Recent mmotm builds on powerpc have been failing with
>>
>> arch/powerpc/mm/mem.c:169: error: âwalk_memory_resourceâ undeclared here (not in a function)
>> cc1: warnings being treated as errors
>> arch/powerpc/mm/mem.c:169: error: type defaults to âintâ in declaration of âwalk_memory_resourceâ
>> make[1]: *** [arch/powerpc/mm/mem.o] Error 1
>>
> Thank you for pointing out.
> -Kame
> ==
>
>
> walk-system-ram-range.patch renames walk_memory_resource()
> to be walk_system_ram_range().
> But powerpc has its own one and it's exported.
> (Because ehea driver (IBM's one) uses this, powerpc export this.)
>
>> arch/powerpc/mm/mem.c:169: error: âwalk_memory_resourceâ undeclared here (not in a function)
>> cc1: warnings being treated as errors
>> arch/powerpc/mm/mem.c:169: error: type defaults to âintâ in declaration of âwalk_memory_resourceâ
>> make[1]: *** [arch/powerpc/mm/mem.o] Error 1
>>
> The patch failed to update powerpc's EXPORT_SYMBOL, this patch fixes it.
>
> Reported-by: Hugh Dickins <hugh.dickins@xxxxxxxxxxxxx>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>


Acked-by: WANG Cong <xiyou.wangcong@xxxxxxxxx>

>
> ---
> Âarch/powerpc/mm/mem.c | Â Â2 +-
> Â1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: mmotm-2.6.31-Sep14/arch/powerpc/mm/mem.c
> ===================================================================
> --- mmotm-2.6.31-Sep14.orig/arch/powerpc/mm/mem.c
> +++ mmotm-2.6.31-Sep14/arch/powerpc/mm/mem.c
> @@ -166,7 +166,7 @@ walk_system_ram_range(unsigned long star
> Â Â Â Â}
> Â Â Â Âreturn ret;
> Â}
> -EXPORT_SYMBOL_GPL(walk_memory_resource);
> +EXPORT_SYMBOL_GPL(walk_system_ram_range);
>
> Â/*
> Â* Initialize the bootmem system and give it all the memory we
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/