Re: [PATCH 2/6] firewire: ohci: fix Self ID Count register mask (safeguardagainst buffer overflow)

From: Stefan Richter
Date: Mon Sep 07 2009 - 15:30:12 EST


pageexec@xxxxxxxxxxx wrote:
On 6 Sep 2009 at 18:49, Stefan Richter wrote:

added stable as .30 is affected, possibly older kernels as well, i didn't check.

The mistake which is fixed here is present since firewire-ohci was added in 2.6.22. However, for a smooth submission to stable, the patched file...

--- linux-2.6.31-rc9.orig/drivers/firewire/ohci.c
+++ linux-2.6.31-rc9/drivers/firewire/ohci.c

...has to be drivers/firewire/fw-ohci.c in kernels before 2.6.31-rc1.

As hinted at in the changelog, I personally don't consider the fix urgent because there are a few more self ID consistency checks in place which catch a variety of real and theoretical corruptions, but I don't claim that I'm appropriately aware of all possibilities.
--
Stefan Richter
-=====-==--= =--= --===
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/