Re: [PATCH 00/12] Gigaset driver patches for 2.6.32

From: Daniel Walker
Date: Mon Sep 07 2009 - 10:31:04 EST


On Mon, 2009-09-07 at 11:07 +0200, Tilman Schmidt wrote:
> Daniel,
>
> thanks for taking a look at my patches.
>
> On Sun, 06 Sep 2009 18:26:46 -0700, Daniel Walker wrote:
> > patches 6,7,10, and 12 all have checkpatch errors. Could you fix those?
>
> I have reissued patch 7, exchanging the "static" and "inline" keywords
> as requested.
>
> The other patches I'd much prefer to keep as they are. The "ERRORs"
> checkpatch.pl reported for them are results of keeping to the existing
> formatting of the patched files. Completely reformatting them would
> cloud the actual changes made by the patches.

Yeah, it looks like the whole file needs a checkpatch clean up.. Sounds
like your not willing to do that? Usually if a checkpatch cleanup comes
first prior to all your other changes , it doesn't usually cloud the
rest of the changes..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/