Re: vfs-fix-d_path-for-unreachable-paths.patch

From: Miklos Szeredi
Date: Mon Sep 07 2009 - 04:34:03 EST


On Sat, 2009-09-05 at 10:22 -0400, Valdis.Kletnieks@xxxxxx wrote:
> Somebody is buggy here, but I'm not sure who. The initrd for leaving a dangling
> reference, the patch for breaking /proc/mounts, or /sbin/restorecon and the
> shutdown script for being far too trusting of what the kernel tells it?
>

Hugh Dickins reported a similar issue, where gnome-vfs chokes on
that /proc/mounts line as well.

I think the conclusion is that this change in /proc/mounts is not going
to work. There are two solutions:

1) leave out unreachable mounts from /proc/PID/mounts altogether
2) completely revert /proc/PID/mounts to the old behavior

The first option is much less likely to break something than the current
patch, but it's still an ABI change.

So I think it's better to go with the second option. Patches coming
up...

Thanks,
Miklos


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/