[PATCH] Make sure the value in abs() does not get truncated if it is greater than 2^32

From: Rolf Eike Beer
Date: Thu Sep 03 2009 - 17:12:38 EST


I was just digging a bit around in linux/kernel.h and stumbled over the abs()
makro. For me it looks as it would return wrong results on 64 bit platforms
if the input value is greater than 2^32.

Signed-off-by: Rolf Eike Beer <eike-kernel@xxxxxxxxx>
---
include/linux/kernel.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index d6320a3..1e6eb66 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -145,7 +145,7 @@ extern int _cond_resched(void);
#define might_sleep_if(cond) do { if (cond) might_sleep(); } while (0)

#define abs(x) ({ \
- int __x = (x); \
+ long __x = (x); \
(__x < 0) ? -__x : __x; \
})

--
1.6.0.2

Attachment: signature.asc
Description: This is a digitally signed message part.