Re: [PATCH V6 1/2] introduce ALS sysfs class

[Rafael J. Wysocki]

On Tuesday 01 September 2009, Pavel Machek wrote:
> 
> > > > IMO, 0 and -1 are not errors. they just suggest that the Ambient Light
> > > > illuminance is beyond the device support range, while the device is
> > > > still working normally.
> > > > what about exporting these values (0 and -1) to user space directly?
> > > 
> > > Returning 0 for "below" range and 99999999 for "above" range would be
> > > nice, yes. 
> > 
> > Why not 0 and "all ones" or 0 and -1.
> > 
> > Is there anything wrong with -1 in particular?
> 
> Normal people expect -1 to be less than 123, and output is in ascii. If
> you make it ((unsigned) ~0) I guess that becomes acceptable.

Well, "-1" is a perfectly valid alphanumerical representation of an int.
I don't really see the problem with the "-", unless we're talking about some
broken user space, that is.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/