Re: [PATCH 1/2] AB3100 regulator support v3

From: Mark Brown
Date: Wed Sep 02 2009 - 13:24:48 EST


On Tue, Sep 01, 2009 at 12:04:18AM +0200, Linus Walleij wrote:
> This adds support for the regulators found in the AB3100
> Mixed-Signal IC.
>
> It further also defines platform data for the ST-Ericsson
> U300 platform and extends the AB3100 MFD driver so that
> platform/board data with regulation constraints and an init
> function can be passed down all the way from the board to
> the regulators.
>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>

This looks basically good - my only concern is if the initialisation
data supplied for the regulators is just setting up the things that can
be set up via the API or if there's other stuff going on (this was my
reason for the question I asked the other day). If there's other stuff
being configured then I'm happy with the patch modulo the static thing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/