[PATCH, v3] isdn: Fix stack corruption in isdnloop_init()

From: Ingo Molnar
Date: Wed Sep 02 2009 - 10:02:34 EST



* Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

> > - char rev[10];
> > + char rev[strlen(revision)+1];
> >
> > if ((p = strchr(revision, ':'))) {
> > strcpy(rev, p + 1);
>
> now it;s a runtime variable sized array.
> NotNice(tm)

ah, indeed - i thought GCC would figure out its constness but it
doesnt. v3 should fix this:

-------------->