Re: [PATCH] dac960: switch to seq_file

[Alexey Dobriyan]

On Tue, Sep 01, 2009 at 04:27:35PM -0700, Andrew Morton wrote:
> On Fri, 28 Aug 2009 23:58:14 +0400
> Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
> 
> >  drivers/block/DAC960.c |  156 ++++++++++++++++++++++---------------------------
> 
> hm, that's a large change to a hard-to-change driver.
> 
> Is it correct?

Nobody knows :-)

In fact I'm pretty sure conversion is correct:
0) ->data is passed as m->private,
1) DAC960_ProcReadStatus() -- print "OK" or "ALERT" if one controller is in alert mode,
2) DAC960_ProcReadInitialStatus() -- print ->CombinedStatusBuffer content, lenght is in ->CurrentStatusLength
3) DAC960_ProcReadUserCommand() -- (2) applied to ->UserStatusBuffer

	"%.*s" does exactly that.

4) DAC960_ProcWriteUserCommand() -- signature change to ->write method, controller is in PDE(...)->data
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/