Re: [PATCH resend] tracing/events: convert NAPI's tracepoint viaTRACE_EVENT

From: Xiao Guangrong
Date: Tue Sep 01 2009 - 23:13:07 EST




David Miller wrote:

> This patch can't be split up, so I'm wondering how you suggest to
> handle this patch given that you have declared that define_trace.h
> changes aren't to go through the subsystem tree?
>
> If we do the define_trace.h change only, we break the build
> (lack of macro defined for the trace).
>
> If we do only the other parts of his patch, we get a duplicate
> definition.
>

This patch cooperate with my previous patch to solve the include file
dependencies problem. So, we do better put those two patches together.
(both in -tip tree or/add both in network tree)

The previous patch is below:

Commit-ID: 5ac35daa9343936038a3c9c4f4d6d3fe6a2a7bd8
Gitweb: http://git.kernel.org/tip/5ac35daa9343936038a3c9c4f4d6d3fe6a2a7bd8
Author: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxx>
AuthorDate: Tue, 25 Aug 2009 14:06:22 +0800
Committer: Steven Rostedt <rostedt@xxxxxxxxxxx>
CommitDate: Wed, 26 Aug 2009 00:32:09 -0400

tracing/events: fix the include file dependencies

> And keep in mind that Neil and Xiao are probably going to want to do
> work on top of this to the networking bits. Thus if we put this patch
> here into the tracing tree, I'll have to develop a dependency on the
> tracing tree and I think that will go over like a fart in a spacesuit
> with the -next crowd and Stephen Rothwell in particular.
>

Thank you, David

Xiao
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/