Re: [mmotm][BUG] free is bigger than presnet Re: mmotm2009-08-27-16-51 uploaded

[KAMEZAWA Hiroyuki]

On Tue, 1 Sep 2009 10:33:31 +0100 (BST)
Hugh Dickins <hugh.dickins@xxxxxxxxxxxxx> wrote:

> On Tue, 1 Sep 2009, KAMEZAWA Hiroyuki wrote:
> > 
> > I'm not digggin so much but /proc/meminfo corrupted.
> > 
> > [kamezawa@bluextal cgroup]$ cat /proc/meminfo
> > MemTotal:       24421124 kB
> > MemFree:        38314388 kB
> 
> If that's without my fix to shrink_active_list(), I'd try again with.
> Hugh
> 
Thank you very much. I missed this patch.
It's fixed.

Regards,
-Kame


> [PATCH mmotm] vmscan move pgdeactivate modification to shrink_active_list fix
> 
> mmotm 2009-08-27-16-51 lets the OOM killer loose on my loads even
> quicker than last time: one bug fixed but another bug introduced.
> vmscan-move-pgdeactivate-modification-to-shrink_active_list.patch
> forgot to add NR_LRU_BASE to lru index to make zone_page_state index.
> 
> Signed-off-by: Hugh Dickins <hugh.dickins@xxxxxxxxxxxxx>
> ---
> 
>  mm/vmscan.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> --- mmotm/mm/vmscan.c	2009-08-28 10:07:57.000000000 +0100
> +++ linux/mm/vmscan.c	2009-08-28 18:30:33.000000000 +0100
> @@ -1381,8 +1381,10 @@ static void shrink_active_list(unsigned
>  	reclaim_stat->recent_rotated[file] += nr_rotated;
>  	__count_vm_events(PGDEACTIVATE, nr_deactivated);
>  	__mod_zone_page_state(zone, NR_ISOLATED_ANON + file, -nr_taken);
> -	__mod_zone_page_state(zone, LRU_ACTIVE + file * LRU_FILE, nr_rotated);
> -	__mod_zone_page_state(zone, LRU_BASE + file * LRU_FILE, nr_deactivated);
> +	__mod_zone_page_state(zone, NR_ACTIVE_ANON + file * LRU_FILE,
> +							nr_rotated);
> +	__mod_zone_page_state(zone, NR_INACTIVE_ANON + file * LRU_FILE,
> +							nr_deactivated);
>  	spin_unlock_irq(&zone->lru_lock);
>  }
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/