Re: [PATCH V5 0/2] Ambient Light Sensor support

From: Dmitry Torokhov
Date: Tue Sep 01 2009 - 03:01:06 EST


On Tue, Sep 01, 2009 at 02:53:02PM +0800, Zhang Rui wrote:
> On Tue, 2009-09-01 at 14:47 +0800, Zhang Rui wrote:
> > On Tue, 2009-09-01 at 14:28 +0800, Dmitry Torokhov wrote:
> > > On Mon, Aug 31, 2009 at 01:04:35PM -0400, Len Brown wrote:
> > > > I put this in the acpi test tree, with the expectation
> > > > that it will have at least one minor revision update
> > > > before going upstream.
> > > >
> > > > thanks,
> > > > Len Brown, Intel Open Source Technology Center
> > > >
> > >
> > > Breaks build here...
> > >
> > that's weird.
> > I didn't encounter this problem in my test.
> >
> PREFIX is defined in include/acpi/acpi_bus.h,
> which has already been included in this driver.
>
> I got this after applying your patch,
> CC drivers/acpi/als.o
> drivers/acpi/als.c:46:1: warning: "PREFIX" redefined
> In file included from drivers/acpi/als.c:30:
> include/acpi/acpi_bus.h:33:1: warning: this is the location of the
> previous definition
>

[dtor@dtor-d630 work]$ grep -r PREFIX include/acpi/acpi_bus.h
[dtor@dtor-d630 work]$

This is acpi test branch merged with latest pull from Linus plus my
for-linus and next branches that don't touch ACPI code.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/